Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating multiple points blanks OSM data layer #6977

Closed
1ec5 opened this issue Oct 27, 2019 · 2 comments
Closed

Rotating multiple points blanks OSM data layer #6977

1ec5 opened this issue Oct 27, 2019 · 2 comments
Labels
bug A bug - let's fix this!
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 27, 2019

Rotating a multiple selection of three points in close proximity causes the entire OSM data layer to go blank.

Steps to reproduce:

  1. Go to https://preview.ideditor.com/master/#map=20.00/39.27909/-84.40139
  2. Select all three picnic tables (nodes 6923427636, 6923427637, and 6923427638).
  3. Rotate this multiple selection.

Expected results: Two of the picnic tables rotate around the middle one.

Actual results: The entire OSM data layer goes blank. Sometimes undoing momentarily restores some of the data, but it quickly vanishes again when changing the selection. The data model seems to be unaffected; I’m able to save existing changes up to but not including the rotation even after things go haywire.

The same thing happens if I duplicate the three points and rotate those points, but not if I draw three new points from scratch and rotate them. So I think it may be specific to the coordinates of these points relative to each other.

Reproduces in both Safari and Firefox, in both 2.16.0 and master (as of defcbe7). In the Firefox console, I see a warning about translate(NaN,NaN) being set on the transform attribute.

@hackily
Copy link
Contributor

hackily commented Oct 28, 2019

Thanks for the detailed reproduction steps!

@bhousel
Copy link
Member

bhousel commented Oct 28, 2019

done in #6979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants