Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue suggestion for outdated Railroad switches (and potentially other railroad features) #7236

Closed
scottAnselmo opened this issue Jan 9, 2020 · 2 comments
Assignees
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Milestone

Comments

@scottAnselmo
Copy link

Problem:
Nodes tagged like this:

disused=yes
railroad=switch

Are being recommended in Id to be changed to
disused:railroad=yes

image

The issue here is that it removes a key identifier (such as it being a switch)

Solution:
Per OSM Wiki, have the add tag instead be disused:railway=<feature> such as disused:railway=switch. So ultimately it would instead look like:

image
Potentially worth fixing for other railway features (e.g. signal) as well if similar Issue suggestion logic applies to them.

@IgorEliezer
Copy link

IgorEliezer commented Jan 9, 2020

Are being recommended in Id to be changed to
disused:railroad=yes
The issue here is that it removes a key identifier (such as it being a switch)

It seems it is not limited to switches. Disused train station disused=yes + railway=station is being replaced with disused:railway=yes (per #7119 (comment)). The railway upgrade is not following the Lifecycle prefix schema.

You use disused:railway=yes only if the type of railway element that it used to be is unknown.

@quincylvania quincylvania added bug A bug - let's fix this! validation An issue with the validation or Q/A code labels Jan 9, 2020
@quincylvania quincylvania self-assigned this Jan 9, 2020
@quincylvania quincylvania added this to the 2.17.1 milestone Jan 9, 2020
@quincylvania
Copy link
Collaborator

Whoops, this was definitely a bug!

@IgorEliezer Sorry for not reading your comment on this closely.

@sanecito Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants