Flat field added to apartment building #7896
Conversation
There was a problem hiding this comment.
Looks pretty good, @ogbeche77, just a couple changes needed before we can merge.
data/presets/fields/flats.json
Outdated
| "key": "flats", | ||
| "type": "number", | ||
| "minValue": 0, | ||
| "label": "Flats", |
There was a problem hiding this comment.
So iD's default language is American English. Could we make the label "Units" instead?
|
Hi @quincylvania |
| @@ -1,5 +1,8 @@ | |||
| { | |||
| "icon": "maki-building", | |||
| "fields": [ | |||
| "building/flats" | |||
There was a problem hiding this comment.
Oh, you should also have "{building}" here the way you did before.
There was a problem hiding this comment.
So it should be "fields": [ "{building}"] ? Without "flats"? or "fields": [ "{building}","flats"] ?
I think I need more time to get more familiar with the code base :)
There was a problem hiding this comment.
Oh.. I think I figured it out. It should be "fields": [ "{building}", "building/flats" ]
:)
|
@ogbeche77 Looks great, thanks for the contribution and for working through the technicalities! Welcome to iD development. |
Hey Maintainers, I am new here and willing to contribute to this community.
I observed that this issue not been resolved, #7856 so I went ahead to implement the change as described by @TheAdventurer64.
A flat field was added to indicate how many flats are in an apartment building. If label needs to be reworded/rephrased, I will gladly do that again.
Cheers