Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disused:amenity transforms area in line #8051

Closed
ferdi2005 opened this issue Oct 4, 2020 · 12 comments
Closed

Disused:amenity transforms area in line #8051

ferdi2005 opened this issue Oct 4, 2020 · 12 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@ferdi2005
Copy link

If I use disused:amenity as tag and theatre as value, the areas becomes a line.
Schermata 2020-10-04 alle 11 53 33

@sun-geo
Copy link
Contributor

sun-geo commented Oct 4, 2020

Which behavior would you expect instead?

@ferdi2005
Copy link
Author

@sun-geo I’d expect to see it as an area, greyed out or with some indication of disused. I’d certainly not expect to see it as a line.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Oct 4, 2020
@quincylvania
Copy link
Collaborator

Hi and welcome, @ferdi2005. This happens because OSM doesn't have a separate area geometry type, so iD guesses what's an area based on the tags. Since iD didn't know whether disused:amenity should be an area, it falls back to line. You can add area=yes to anything like this to make it an area.

I added an unsearchable Disused Amenity preset to fix this.

@quincylvania quincylvania added this to the 2.19.0 milestone Oct 4, 2020
@quincylvania quincylvania self-assigned this Oct 4, 2020
@ferdi2005
Copy link
Author

ferdi2005 commented Oct 5, 2020

@quincylvania and can’t you add that iD recognizes disused:amenity as an area tag like amenity?

@quincylvania
Copy link
Collaborator

can’t you add that iD recognizes disused:amenity as an area tag like amenity?

Yes, this is what I did here:

I added an unsearchable Disused Amenity preset to fix this.

@ferdi2005
Copy link
Author

@quincylvania Thanks!

@rhhsm
Copy link

rhhsm commented Oct 28, 2020

I added an unsearchable Disused Amenity preset to fix this.

The issue also applies to buildings, both disused: and abandoned: . In addition, these buildings no longer appear on the OSM map. I'm tempted to use building=house & disused=yes instead of disused:house=yes even though this is discouraged, because the issue doesn't occur here. I think disused:house=yes should be displayed the same as building=house & disused=yes (brick red area with dotted perimeter).

@quincylvania
Copy link
Collaborator

@rhhsm Yes, there are many combinations of status:key that people use in OpenStreetMap, but I think it'd be over-the-top to try and support all of them as presets. I'd discourage using the disused:building tag specifically, since a building is still a building even when no one is using it.

@rhhsm
Copy link

rhhsm commented Oct 29, 2020

Consensus on the OSM wiki is that the simple tag is discouraged in favour of the prefix for reasons given here for instance https://wiki.openstreetmap.org/wiki/Key:abandoned: I think the software should be adapted to the consensus, not the other way around. Probably to create presets for all cases is not the most elegant solution (but I'm not a coder).

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 29, 2020

  1. https://wiki.openstreetmap.org/wiki/Key:abandoned is for abandoned, not disused

  2. https://wiki.openstreetmap.org/wiki/Key:abandoned specifically indicates that building=* + abandoned=yes is superior to abandoned:building

  3. I just edited https://wiki.openstreetmap.org/wiki/Key:disused: to indicate that disused:building is a bad idea (feel free to discuss it on wiki/tagging mailing list/OSM Telegram/US Slack/...)

@HolgerJeromin
Copy link
Contributor

Your link lost the :. Right is: https://wiki.openstreetmap.org/wiki/Key:disused:

@matkoniecz
Copy link
Contributor

Your link lost the :

Thanks, fixed. Github tried to be helpful and delinked trailing :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

6 participants