Disallow changing feature type of locked feature

[1ec5]

When a feature is locked (because of a Wikidata tag), iD disables the feature’s Name field to prevent name vandalism, a common kind of vandalism. But it’s also probably common to vandalize or accidentally break a prominent feature by changing its type. When a locked feature is selected, iD should also disable the Feature Type button and the sidebar’s back button. When the nature of a feature does legitimately change, or in case it was originally mistagged, the user would still be able to change the feature’s type using the raw tag editor or unlock the feature by removing the Wikidata tag.

Some examples of mistaken or mischievous edits to Wikidata-tagged features:

• School changed to park, most likely tagging for gameplay (though this change predates Wikidata tagging and the locking feature)
• Park changed to recreation ground, tagging against gameplay (though this change predated the Wikidata tag and the vandal got more clever over time)
• Administrative boundary relation changed to speed limit enforcement relation, probably by mistake somehow

[cliffordsnow]

If I understand the implications, then the lock would prevent vandalism to city names, such as New York City was a few years ago. It would also prevent the name change to oceans and seas if they have the appropriate wikidata id. I'd support this change.

One question - If I can change the wikidata entry, how would this impact the feature.

[1ec5]

If I understand the implications, then the lock would prevent vandalism to city names, such as New York City was a few years ago. It would also prevent the name change to oceans and seas if they have the appropriate wikidata id.

The locking feature was introduced in #6389 and already disallows changes to the Name field. This feature request is about extending the protection to the Feature Type button that sits above it in the sidebar, so you can’t change a city to a convenience store, for example.

If I can change the wikidata entry, how would this impact the feature.

It is possible to unlock a feature by removing any wikidata or *:wikidata tag. The locking feature is meant to deter only the most casual of vandals. The New York City incident was carried out by a much more sophisticated JOSM user, so this locking feature would not have prevented it at all. Even so, I figure there’s some value in extending locking to protect the most basic attribute of a prominent feature.

It’s also possible to vandalize the linked Wikidata item’s labels, which some renderers use in conjunction with OSM data. But Wikidata has more robust countervandalism measures, such as semiprotection (new users can’t edit the New York City item) and IP address blocking.