Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support special styling for Wikidata-tagged features #6389

Merged
merged 5 commits into from
May 20, 2019
Merged

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented May 19, 2019

I'm experimenting with the idea of giving a special style to features that have been tagged with a wikidata or brand:wikidata tag. These features have some extra protections put in place to prevent accidental name changes and deletions, so it would be helpful to indicate that they are special somehow.

Screenshot 2019-05-18 23 56 49

I kind of don't like the green, but might keep it or do something else. Maybe I'll leave the text halos white. Or maybe something similar to how verified accounts on Twitter get a special badge. I don't want something that steals the user's attention so much.

@BjornRasmussen
Copy link
Contributor

How about keep the text halo white, and make the icon light gray instead of green?
Buildings wouldn't be changed by this, though, so perhaps they could get something else

@Adamant36
Copy link

"How about keep the text halo white, and make the icon light gray instead of green?"

That was totally going to be my suggestion.

@bhousel
Copy link
Member Author

bhousel commented May 20, 2019

Another try, this time with just subtle green stroke. It's better, but still not sure if I like it.
I don't really want to make them gray, because they aren't really readonly.

Screenshot 2019-05-20 00 33 06

@1ec5
Copy link
Collaborator

1ec5 commented May 20, 2019

A halo would conflict with the blue halo for relation members. How about boldfacing, italicizing, or underlining the label (when shown), assuming that most Wikidata-linked features would have names? This approach has the additional benefit of being useful to those with color blindness.

@bhousel
Copy link
Member Author

bhousel commented May 20, 2019

I ended up doing this

On the map:

  • Point markers with locked fields have a gray outline and slight gray fill
  • Nothing special for area icons

On the sidebar:

  • Locked fields get a lock 🔒
  • Locked fields don't get revert ↩️or delete buttons 🗑
  • Same calculation as before for locking a field
    • if wikidata tag is set, lock name
    • if brand:wikidata tag is set, lock either name or brand

Screenshot 2019-05-20 17 52 22

Screenshot 2019-05-20 17 54 11

Screenshot 2019-05-20 17 53 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants