Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow operation should prefer the focused way #8750

Open
1ec5 opened this issue Oct 13, 2021 · 8 comments
Open

Follow operation should prefer the focused way #8750

1ec5 opened this issue Oct 13, 2021 · 8 comments
Labels
enhancement An enhancement to make an existing feature even better

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 13, 2021

The “follow” operation added in #8671 stops when encountering a node that’s shared among multiple features. iD already keeps track of the “focused” way for the purpose of reliably navigating back and forth among its vertices using the keyboard. It would be natural to extend this capability to the follow operation, so that the user doesn’t have to think as much about other connecting ways after choosing a way to follow. Invoking the follow operation would focus the way, and subsequent follow operations would choose that way from among the candidate ways.

function parentWayIdForVertexNavigation() {
// `_focusedParentWayId` is used when we visit a vertex with multiple
// parents, and we want to remember which parent line we started on.
var _focusedParentWayId;

@1ec5 1ec5 added the enhancement An enhancement to make an existing feature even better label Oct 13, 2021
@mbrzakovic mbrzakovic added the good first issue Best for first-time contributors. No experience necessary! label Nov 2, 2021
@Pho3b
Copy link

Pho3b commented Jan 23, 2022

Hi and nice to meet you @mbrzakovic @1ec5 , i would like to try and work on this issue if possible.

@thyrhone
Copy link

thyrhone commented Mar 2, 2022

is it still possible to work on this?

@1ec5
Copy link
Collaborator Author

1ec5 commented Mar 2, 2022

Thanks for your interest! There’s a fix available in #8978; perhaps you could help review it?

@sherryboxall
Copy link

Hello @mbrzakovic @1ec5 ,

I would like to help work on this issue if possible. Thank you!

@Dustpie
Copy link

Dustpie commented Apr 28, 2022

Can I still help on this issue if possible? Thank you!

@Gua00va
Copy link

Gua00va commented Feb 15, 2023

Hey!! I want to work on this issue. I'm new here so I'm really excited to start contributing. Please assign it to me.

@k-yle
Copy link
Contributor

k-yle commented Feb 16, 2023

This issue has already been fixed in two conflicting PRs: #8978 and #9340

I'm guessing the suprising interest in this issue is because it has a "good first issue" label. @tyrasd it might be good to add this label to some other issues like #9452, #9217, #9448, #9441, #9440, #9312, #9402, #9400, ...

@1ec5
Copy link
Collaborator Author

1ec5 commented Feb 16, 2023

Right, GitHub has a feature that suggests issues labeled as good first issue Best for first-time contributors. No experience necessary! to users, but it doesn’t consider whether there are outstanding PRs already linked to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

No branches or pull requests

9 participants