create a quick method of drawing ways

[k-yle]

Closes #1614

When drawing an new way/area that abuts an existing way/area, it becomes quite boring clicking on each node to join your new area to the existing one.

This PR allows you to press F while drawing a way/area to automatically keep drawing the new way along the edge of the existing way.

Example video: After drawing 3 nodes manually, I press F repeatedly to continue drawing

race.mp4

This is really helpful when mapping landuse/vegetation.

Outstanding issues: (I need help/guidance with these please)

• Not sure if 7 is the right key for this. Just a random choice Changed to F, so the key to open the settings pane is now U.
• I think I've registered the keybindings wrong, because it should only work while drawing a way. fixed
• Not sure what the techincal name for this feature is. I've called it 'race mode' for now. Renamed it to 'Follow'
• There's a bug when you pass the first/last node of a closed way fixed

Limitations:

• It's not smart enough to work in this situation - if there are already two ways sharing the same nodes, it can't help you join a third way to those nodes

[bhousel]

nice! this is #1614

[jjiglesiasg]

Worth more than a try. Thanks

[k-yle]

thanks @bhousel, ironically I 👍'd that issue and then forgot about it - happy to close this PR if #7649 is a more robust solution

[bhousel]

thanks @bhousel, ironically I 👍'd that issue and then forgot about it - happy to close this PR if #7649 is a more robust solution

I think what you built is perfect, though it would be nice to use whatever key Potlatch or JOSM uses for this feature (if possible), instead of 7.

[pnorman]

I think JOSM's default is f for "follow".

[k-yle]

I've updated it to use F. Currently F is being used to open the settings pane, so we'll need a new shortcut for settings (I've changed it to U for now).

I've been mapping landuse and vegetation from this branch over the past 2 days and it's been working quite well

[k-yle]

not sure why tests for iD.modeAddNote are failing, it seems to be unrelated to this PR

[mbrzakovic]

not sure why tests for iD.modeAddNote are failing, it seems to be unrelated to this PR

It is unrelated. I thought I solved this in #8635 I will take a second look into this, please ignore it for now.

[1ec5]

On the one hand, it’s convenient that the F accelerator key matches the follow operation in Potlatch (miss you) and JOSM. On the other hand, we’re starting to run out of unmodified accelerator keys, especially ones that are reachable by the left hand.¹ It’s forcing localizations that localize keys to play successive rounds of musical chairs. But that’s a broader issue and shouldn’t hold up this PR.

Perhaps a future enhancement could also assign the ⌘[ and ⌘] keys to this operation. It would be elegant to “zip” a way together with another way using the normal keyboard shortcuts for navigating along a way.

Footnotes

1. If I remember correctly, some of the accelerator keys were chosen to be reachable by the left hand, assuming the right hand is operating a mouse in tandem. But I can’t remember where I saw that stated. ↩