Ban some (copyrighted) custom background

[zbycz]

Description

We have this issue in czech community: some begginers are using copyrighted custom background when editing OSM.

In the whole database, there is around 11000 edits so far. Of course members of community are educating those users and reverting the changes, but we would like to ask, if it could be somehow banned in iD itself. It is becoming a little tedious :-)

• Proposed change: when custom background hostname contains "mapy.cz", warn the user and disable the Save button.

.

Here is our thread in czech: https://openstreetmap.cz/talkcz/c3793 (translator)

Screenshots

No response

[1ec5]

iD has a validation rule for warning about the use of some common copyrighted sources. mapy.cz can be added to this object:

iD/modules/validations/incompatible_source.js

Lines 8 to 22 in 446133d

	const incompatibleRules = [
	{
	id: 'amap',
	regex: /(^amap$|^amap\.com|autonavi|mapabc|高德)/i
	},
	{
	id: 'baidu',
	regex: /(baidu|mapbar|百度)/i
	},
	{
	id: 'google',
	regex: /google/i,
	exceptRegex: /((books|drive)\.google|google\s?(books|drive|plus))|(esri\/Google_Africa_Buildings)/i
	}
	];

[pnorman]

iD has a validation rule for warning about the use of some common copyrighted sources. mapy.cz can be added to this object:

Aren't these rules about source tags, while this issue is about imagery URLs? Blocked imagery URLs are set by the editing API in the /capabilities response, which are set at https://github.com/openstreetmap/openstreetmap-website/blob/0e00857d51f2890071698b8ac9e699ce444aa3a3/config/settings.yml#L85

[tyrasd]

@pnorman is right: The proper place to add this restriction is at the imagery policy of the OSM API. Please open a ticket for that on the openstreetmap-website.

[Jakuje]

Filled openstreetmap/openstreetmap-website#4085 for this.

[tyrasd]

perfect. 👍

Just a small nit-pick:

they do not have a way to fix it on their side

this is not quite right… we could fix it on iD's side, but it just doesn't make sense: it's much better to do this using the existing functionality of the OSM API, as it will then have an effect in all (properly implemented) OSM editors, not just in iD. 😊