Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button in the mapillary image photo viewer to "add the current image id as field to feature" #10046

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Add a button in the mapillary image photo viewer to "add the current image id as field to feature" #10046

wants to merge 20 commits into from

Commits on Dec 20, 2023

  1. Add set button and view button at mapillary field (openstreetmap#9339) 

    more info see openstreetmap#6196 (comment)
I do the b. (set button) and c. (view button)
order: click OSM object -> click mapillary layer will close the OSM input field. need to do in reverse order
    @laigyu
    laigyu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    87f0014 View commit details
    Browse the repository at this point in the history

  2. fix setButton when imageChange disabled

    @laigyu
    laigyu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a2296cf View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. fix button title

    @laigyu
    laigyu committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    33f4f8e View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Add set mapillary id button in the mapillary photo viewer 

    It is the a. part in openstreetmap#6196 (comment)

still need to add button disabled logic
    @laigyu
    laigyu committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    5890b79 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Update icon to '#iD-operation-merge'

    @laigyu
    laigyu committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6523ae6 View commit details
    Browse the repository at this point in the history

  2. update core.yaml

    @laigyu
    laigyu committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2b0e0f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Update set_photo_from_viewer button create/remove logic 

    refactor the code expandability for other photo_overlay

Not sure about context.features().on('change'), and hash part
    @laigyu
    laigyu committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0ef947d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. update open the viewer button logic 

    1 problem remain: if entity select and close the photoviewer,
view button will not update class, still clickable though
    @laigyu
    laigyu committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    437ecf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Add error message in photoviewer when invalid id 

    and update input.js
    @laigyu
    laigyu committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    0ad46e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. finish open the viewer button logic 

    button disable class reacts to photoviewer close
    @laigyu
    laigyu committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    cc10898 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. refactor the code

    @laigyu
    laigyu committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b597cc1 View commit details
    Browse the repository at this point in the history

  2. code style change

    @laigyu
    laigyu committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    666bbbf View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. refactor the code 

    '_' change to '-'
    @laigyu
    laigyu committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6b860b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Merge remote-tracking branch 'upstream/develop' into add-button-to-ma… 

    …pillary
    @laigyu
    laigyu committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8bb1d0d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. revert field button

    @laigyu
    laigyu committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    94e32a8 View commit details
    Browse the repository at this point in the history

  2. revert error handler

    @laigyu
    laigyu committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    d448b58 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. tooltip style change

    @laigyu
    laigyu committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6b8b41c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. update butotn logic

    @laigyu
    laigyu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2325de4 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. tooltip update

    @laigyu
    laigyu committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b1ff86c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'openstreetmap:develop' into add-button-to-mapillary

    @laigyu
    laigyu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    904c802 View commit details
    Browse the repository at this point in the history