Sort "more fields" dropdown items #10181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a bad idea. 👍 Since the user may not intuit the difference between a universal field and a non-universal one, maybe there should be a horizontal divider or some other visual distinction. |
Could be - i wanted to submit the simplest mergable solution. Lets see if it will be approved 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more fields combo dropdown offers 1)
moreFieldsfrom the current preset and 2) all fields withuniversal:true. Currently they are all mixed together.This PR sorts the dropdown so the moreFields are displayed first, and the universal below.
The idea is, that user would like to know which fields are relevant to the specific preset first, and not to look for them among all the universal ones.
Screenshot
eg. for train track (w166662057)