Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waterway=flowline to waterway tags representing directional water flows #10283

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

waldyrious
Copy link
Contributor

Currently, lines with waterway=flowline are represented as generic waterway features, and don't get the arrows pointing in the water flow direction along their length (as is the case with rivers, streams, canals, etc.). This change adds the tag so the representation is consistent with the other flowing waterway tags.

@JesseWeinstein
Copy link

It might be worth making them slightly visually different, just so it's easier to tell if a waterway thru a water body has been converted yet. Maybe a slightly different shade of blue?

@tordans
Copy link
Collaborator

tordans commented Jun 19, 2024

For easy reference: https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dflowline , ~800 usage globally.

@tordans

This comment was marked as resolved.

@waldyrious
Copy link
Contributor Author

The wiki sounds like this is something that indicates a direction as well?

Does it? I read the opposite:

Unlike most waterway=* values, the tag does not model a discrete physical feature and does not imply a flow direction.

(emphasis mine)

@waldyrious
Copy link
Contributor Author

It might be worth making them slightly visually different, just so it's easier to tell if a waterway thru a water body has been converted yet. Maybe a slightly different shade of blue?

Sounds good to me, but I didn't want to do too dramatic a change. Happy to add the change if maintainers agree it makes sense.

@tordans

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants