Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer imagery marked as `best` in editor-imagery-index #2841

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
2 participants
@bhousel
Copy link
Member

commented Nov 24, 2015

  • Sorts the best imagery at the top of the background list
  • Pick it automatically if the url hash doesn't specify an imagery source
  • Also bump "none" to the bottom of the list
  • re: #2826 #1310

cc @pnorman @planemad @lxbarth thoughts?

Before After
#map=14.96/8.2276/47.5272 #map=14.96/8.2276/47.5272
screenshot 2015-11-24 11 18 27 screenshot 2015-11-24 11 18 16
Prefer imagery marked as `best` (closes #2826)
* Sorts the imagery at the top of the background list
* Pick automatically if the url hash doesn't have another imagery chosen
* also fixes #1310
@planemad

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2015

@bhousel awesome! does it switch by default to the best imagery for a location on opening iD?

@bhousel

This comment has been minimized.

Copy link
Member Author

commented Nov 24, 2015

Yes it will try to pick the best one - as long as the url includes map coordinates and doesn't include something like background=Bing

@planemad

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2015

👍

bhousel added a commit that referenced this pull request Nov 25, 2015

Merge pull request #2841 from openstreetmap/best-imagery
Prefer imagery marked as `best` in editor-imagery-index

@bhousel bhousel merged commit 0e203c6 into master Nov 25, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bhousel bhousel deleted the best-imagery branch Nov 25, 2015

@tyrasd tyrasd referenced this pull request Nov 26, 2015

Closed

Add AGIV imagery #2846

@bhousel bhousel referenced this pull request Jan 8, 2016

Closed

UI hint for "best" imagery #2902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.