Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer imagery marked as best in editor-imagery-index #2841

Merged
merged 1 commit into from Nov 25, 2015
Merged

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Nov 24, 2015

cc @pnorman @planemad @lxbarth thoughts?

Before After
#map=14.96/8.2276/47.5272 #map=14.96/8.2276/47.5272
screenshot 2015-11-24 11 18 27 screenshot 2015-11-24 11 18 16

* Sorts the imagery at the top of the background list
* Pick automatically if the url hash doesn't have another imagery chosen
* also fixes #1310
@planemad
Copy link
Contributor

@bhousel awesome! does it switch by default to the best imagery for a location on opening iD?

@bhousel
Copy link
Member Author

bhousel commented Nov 24, 2015

Yes it will try to pick the best one - as long as the url includes map coordinates and doesn't include something like background=Bing

@planemad
Copy link
Contributor

👍

bhousel added a commit that referenced this pull request Nov 25, 2015
Prefer imagery marked as `best` in editor-imagery-index
@bhousel bhousel merged commit 0e203c6 into master Nov 25, 2015
@bhousel bhousel deleted the best-imagery branch November 25, 2015 04:43
@tyrasd tyrasd mentioned this pull request Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants