Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Indoor mode #3097
I am submitting a little larger pull request. I am not sure if its possible to be merged as is, but I did my best and will be happy to cooperate further to make it so.
I’ve been engaged in OpenStreetMap since 2008 and for the time being I’ve led many workshops, written some school works and worked on getting the Czech community together on openstreetmap.cz. Last summer I had to come up with a topic for my final engineer thesis, so I decided to use the effort already invested in indoor mapping and chose to update the iD editor accordingly. Let me elaborate...
There are two challenges for indoor:
Several examples (my build):
Well, i think I made my point - let’s discuss the technical background :-)
Some thoughts / questions:
Something to do in future
Changelog until now:
btw, it was a pleasure to work with iD codebase, also d3 is so very amazing :-)
Wow, impressive work @zbycz! I really like this and would like to see this merged in some form.
I'll need some time to think about how to present the UI in a way that doesn't clutter things up too much.
I'll try to answer your questions now:
I think it's ok to call it indoor mode. (People will call it that anyway). You're right it's not technically a "mode" like the other exclusive drawing modes.
I'm leaning towards having the button smaller but available, maybe just an icon with tooltip, and it can transition open to reveal the indoor drawing controls when active. (I'm struggling with this same problem on #2699 - it's cool and useful, but where to put it?)
The right thing to do is to make a proposal and loop in the OSM tagging list. At this point, indoor editing is not solidly established, so I think you have a good chance of pushing the community in a sane direction.
Makes sense.. Yes I agree that in "indoor mode" the building outline should not render as an area, as this covers up the indoor features.
It would be better to squash them into fewer commits, but I'm not super picky about this.
I'll try to review it in more detail, but what I saw at a quick glance looks great! And the tests are much appreciated...
Thanks, @bhousel !
I will make the proposal next week, in the meantime I am looking forward to your code comments
ad button positioning) the more buttons, the more the user think how complex the software is (aka Norman: The design of everyday things) - and I think iD should stay "simple". But also its a bad practise for controls to disappear unexpectedly.
I completely agree with a smaller icon expanding to full control. What about placing Indoor-mode button in a dropdown menu "Tools" on the right of the top toolbar. It could be left closed forever, or left toggled opened. It would be a nice drawer for more useful tools in the future (including the #2699).
I've been playing around with making the UI more responsive and supporting something like a "drawer" for more commands or options on existing commands.
I don't really like it.. Maybe @samanpwbb has ideas?
The problem is it either bumps down the other things in the layout, or it overlaps them. So we'd either need to 1. position the other UI stuff differently or 2. be ok about having them move (eh) or 3. something else.
Great! We are thinking a lot about plugins lately and I would love to find a good way to merge your work into iD to make indoor editing easy for everyone.