Mapillary js #3128

kepta · 2016-05-23T13:59:49Z

Continuing from #3014 , thanks to @peterneubauer.

Things remaining

Toggle signs layer if and only if image layer is enabled.
Look into Resource not found when using mapillaryJS mapillary/mapillary-js#133
Async loading of CSS
Async loading of JS

kepta · 2016-05-24T07:48:55Z

Build Process Issues:

The mapillary-js.min.js file is 1.1MB in size. To give some perspective, the entire iD.js file is roughly 2MB in size. If I try to add mapillary-js.min.js to js/lib folder the make process takes forever to complete. Currently, I am directly copying the mapillary-js.min.js to dist folder in order to avoid concatenating it with iD.js
The svg dependencies of mapillaryJS require them to be hosted on the same level as that of the Mapillary css file. So I am directly copying these files to dist folder as of now :(.
Resource not found when using mapillaryJS mapillary/mapillary-js#133

@bhousel @peterneubauer your views on this?

peterneubauer · 2016-05-24T13:16:22Z

Hi there,
I upgraded to MapillaryJS 1.3 in a2f3063 which makes the local artifacts unnecessary, also the SVGs can be removed.

Regarding the API call- the image you are looking for is from today, we have some lag in the system. Try anything older than a day, e.g. https://a.mapillary.com/v2/nav/im/1gE6B94DP0iDmUHjtRFKcQ?client_id=NzNRM2otQkR2SHJzaXJmNmdQWVQ0dzo1ZWYyMmYwNjdmNDdlNmVi

/peter

pnorman · 2016-05-24T19:27:21Z

js/id/services/mapillary.js

        if (!imageKey) return;
-
+//         console.log('hello world');


commented out debug comment left in here

oh thanks for catching that pnorman 👍

peterneubauer · 2016-05-25T05:05:07Z

I see that the in line mapillary icons and svg is still in here. Is that mandatory or could we just refer to the js and css in index.html for easier upgrade?

kepta · 2016-05-25T07:32:09Z

@peterneubauer we generally keep js/css libraries in the code base itself.

@bhousel when asynchronously loading css/js do we want to use their CDN or host a copy within iD?

bhousel · 2016-05-25T19:05:46Z

@bhousel when asynchronously loading css/js do we want to use their CDN or host a copy within iD?

Probably better to send this stuff to the CDN.. That helps the OSM folks a bit.

kepta · 2016-05-27T04:29:08Z

The implementation is almost complete.
Here is a gif to show how it looks like currently

…nsitions Old behavior would redraw only after the map stops moving for 300ms New behavior will force redraw within 750ms, regardless of map stability

bhousel · 2016-05-27T20:13:24Z

The gif doesn't do it justice, but centerEase is now 👌
Before it was just firing off 10 little map moves.. Now we smoothly interpolate to the new location, adjusting the projection each animation frame and queueing redraw for later.

Jumpy left/right behavior is unnecessary now that centerEase works great

(Viewer object shows the image while loading)

…ad timing

bhousel · 2016-06-01T04:26:53Z

This is working alright!
Thanks @kepta and @peterneubauer for your work on this...
Merging 👍

peterneubauer · 2016-06-01T07:33:07Z

Super work @kepta ! Also, is this working even for street signs correctly?

peterneubauer · 2016-06-01T07:34:24Z

I guess we should soon implement submission of changes to the locations/angles to Mapillary :)

bhousel · 2016-06-01T20:20:35Z

Also, is this working even for street signs correctly?

Yes, it's working for the signs layer also.. The one change we made is that now the photo layer must be activated before the signs layer can be activated.

I guess we should soon implement submission of changes to the locations/angles to Mapillary :)

Sure! If there are some more API calls that would be useful to make, like for tagging or blurring or moving the markers, open a new issue so we can keep track of it..

adding MapillaryJS, first stab.

8782c14

kepta added the wip Work in progress label May 23, 2016

kepta mentioned this pull request May 23, 2016

adding MapillaryJS, first stab. #3014

Closed

kepta force-pushed the mapillary_js branch 2 times, most recently from 16a5ca3 to 7384480 Compare May 23, 2016 14:18

kepta mentioned this pull request May 24, 2016

Resource not found when using mapillaryJS mapillary/mapillary-js#133

Closed

kepta force-pushed the mapillary_js branch from 7384480 to c60354d Compare May 24, 2016 14:23

pnorman reviewed May 24, 2016
View reviewed changes

kepta force-pushed the mapillary_js branch from c60354d to f845b87 Compare May 25, 2016 09:56

Mapillary Js, second stab

f81ff29

kepta force-pushed the mapillary_js branch from f845b87 to f81ff29 Compare May 25, 2016 10:31

temporary css fixup

6b70cf3

bhousel added 2 commits May 27, 2016 15:52

Smooth centerEase with duration param

ee647c8

Remove clearTimeout from queueRedraw, for long mousedrags or ease tra…

e6c440c

…nsitions Old behavior would redraw only after the map stops moving for 300ms New behavior will force redraw within 750ms, regardless of map stability

bhousel added 9 commits May 27, 2016 21:38

Keep thumbnail on left

d13715e

Jumpy left/right behavior is unnecessary now that centerEase works great

Don't show thumbnail when hovering over Mapillary markers

0eac0ff

Allow Mapillary signs layer only if image layer is already enabled

368b861

Remove static Mapillary thumbnail image

d728059

(Viewer object shows the image while loading)

WIP: simplify code, attempt to preload viewer

a99f54b

Load mapillary viewer assets dynamically from CDN

6788f79

WIP: preload viewer when layer enabled, still bad issues with slow lo…

e57914d

…ad timing

Show loading spinner in loadchanged, update selection in nodechanged

e364b7e

Refactor click tracking into Mapillary service, addl cleanups

ca79638

bhousel merged commit 30dfdeb into master Jun 1, 2016

bhousel deleted the mapillary_js branch June 1, 2016 04:29

bhousel removed the wip Work in progress label Jun 1, 2016

bhousel mentioned this pull request Jun 7, 2016

Update to iD v1.9.6 openstreetmap/openstreetmap-website#1233

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mapillary js #3128

Mapillary js #3128

kepta commented May 23, 2016 •

edited

kepta commented May 24, 2016 •

edited

peterneubauer commented May 24, 2016

pnorman May 24, 2016

kepta May 25, 2016

peterneubauer commented May 25, 2016

kepta commented May 25, 2016 •

edited

bhousel commented May 25, 2016

kepta commented May 27, 2016

bhousel commented May 27, 2016

bhousel commented Jun 1, 2016

peterneubauer commented Jun 1, 2016

peterneubauer commented Jun 1, 2016

bhousel commented Jun 1, 2016

Mapillary js #3128

Mapillary js #3128

Conversation

kepta commented May 23, 2016 • edited

Things remaining

kepta commented May 24, 2016 • edited

peterneubauer commented May 24, 2016

pnorman May 24, 2016

Choose a reason for hiding this comment

kepta May 25, 2016

Choose a reason for hiding this comment

peterneubauer commented May 25, 2016

kepta commented May 25, 2016 • edited

bhousel commented May 25, 2016

kepta commented May 27, 2016

bhousel commented May 27, 2016

bhousel commented Jun 1, 2016

peterneubauer commented Jun 1, 2016

peterneubauer commented Jun 1, 2016

bhousel commented Jun 1, 2016

kepta commented May 23, 2016 •

edited

kepta commented May 24, 2016 •

edited

kepta commented May 25, 2016 •

edited