Adding playground presets #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a fun PR! Per your todos:
I added a few other comments.. I know picking icons is tough, but I think we should not use the "entrance" icon for the slide, even though it does look kind of like a slide. Using the same icon for 2 very different concepts makes the map harder to use. |
bhousel
suggested changes
Sep 25, 2017
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "icon": "entrance", | |||
There was a problem hiding this comment.
Haha not sure how I feel about this one..
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "key": "max_age", | |||
| "type": "text", | |||
There was a problem hiding this comment.
min_age and max_age can both be fields and have type number. This will add up/down buttons to the side.
| "playground/baby": { | ||
| "key": "baby", | ||
| "type": "check", | ||
| "label": "Baby Seat" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4252
Presets Added
Things to do
Add a new field for theswingpreset that says whether it has a special wheelchair seatbabyfield on theswingpresetI changed it from
Designed for babiestoBaby seat, but I'm still unsure if I like this or notplaygroundpreset, such as operator and age restrictions