Create features from geoservices #4633
Conversation
… same for OSM features)
This backs out many of the changes from the previous few commits - need to be able to render, select entities, use entity editor, etc - so, keep them in the graph, but we'll formalize a `status` property - imported entites will have `status=pending` still todo: - import code should avoid using d3 to select visible features.. - much of the code to "merge" existing features is commented out for now - more cleanup - UI stuff
This commit also moves the rest of the state varialbes into services/geoservice
|
What does the "Add data to roads" checkbox do? |
I'm not really sure, but I'm planning to go over the entire UI and make sure everything is really easy for a novice to understand. This will probably involve breaking up the single screen into a several step wizard. |
|
@bhousel @tallguy that checkbox is the feature which I mentioned in an earlier comment:
So it draws a buffer around imported data and visible roads, and tries to add attributes to an existing road. |
|
@mapmeld That is very cool! Import attributes by buffer could be a great way to get road attributes like speed limit or lane count into OSM. Governments usually have that in centerline format. Come to think of it, I wonder if you could move the road to match the imported centerline, preserving the OSM tags. It would be great for correcting road alignments with good GIS data. |
|
This feature will now be more useful than ever:
|
|
A quick hup: any news on this one? I'm working with @OxfordshireCountyCouncil on an OSM-based conflation project and it'd be great to suggest people use iD (even if an externally hosted instance) rather than having to faff with JOSM. |
Sorry, @systemed nothing yet! Our goals for this year are tackling validation first and then building an amazing version of this next. In the meantime you can try out @mapmeld's fork here: https://github.com/mapmeld/iD |
|
@bhousel I see that validation is about to be merged. Yay. What can we do to accelerate this acceptance? It’s been quite awhile and the next steps are unclear. You mention “building an a amazing version of this” which implies it will be reimplemented. Can you provide some specifics about the plans? |
|
Hey @ajturner, I just wanted to point out that wasn't a very friendly way to phrase your question. The "Yay." comes off as pretty sarcastic and frames an otherwise decent question about the status of this PR in a bad light. |
Assume good faith ;) |
|
Is there a possibility of merging the existing code (once updated to compliance with master) behind a feature flag so that it could be used by those who know about it and have been trained, but doesn't appear for all of the users of iD? That would let us then move forward with improvements without this PR hanging out there. |
|
Hey @ajturner, @jgravois, @slibby .. A few weeks ago I said on Twitter that “people will soon be able to import data into @openstreetmap just as easily as they are currently able to trace it from aerial imagery.” and I mean it.. Your PR lays the groundwork to make this ambitious goal a reality, and I am very grateful for the work that your team has done. Bringing in data from external services is an idea that makes people in OSM uncomfortable, which is why we decided that stronger validation capability in iD was our first priority. @quincylvania and others made that a reality and released the initial version of it this week in v2.14. When I return from vacation, work on the import tool will be a top priority, and it should ship in the next few months. |
|
I closed this one out because I'm no longer at Esri and it didn't seem like there was much hope of it landing. whether that is the case or not, we'd love to keep the discussion alive. if there'd be any benefit to re-opening, just say the word. |
|
Where to next @jgravois ? |
|
RapiD person here- our plans are still in the incubation phase, but we're definitely keeping an eye on this PR (as you can see!) and considering taking parts of it into the work we're doing. |
demoed at SOTMUS US 2017. resolves #4164.
Fetch service metadata and confirm license is valid:
Re-add a service with a license that was previously confirmed:
Map service attributes to OSM tags and import the features in view:
Review and approve individual features:
we can continue to use the fork issue tracker if the discussion here gets difficult to follow.
cc/ @slibby @mapmeld (primary dev)