Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JSONP with XHR where possible #5123

Merged
merged 4 commits into from Jul 5, 2018
Merged

Replace JSONP with XHR where possible #5123

merged 4 commits into from Jul 5, 2018

Conversation

tomhughes
Copy link
Member

This addresses #5040 by replacing JSONP with XHR where we can, namely:

  • Bing imagery metadata access
  • Esri imagery metadata access
  • Wikipedia API access
  • Wikidata API access

The only thing still using JSONP after this is Streetside because that doesn't currently have CORS support as far as I know.

@bhousel
Copy link
Member

bhousel commented Jul 5, 2018

Thanks @tomhughes for this! Just tried it out and it works great 👍

@bhousel bhousel merged commit faf12a1 into openstreetmap:master Jul 5, 2018
@bhousel bhousel mentioned this pull request Jul 5, 2018
Closed
@tomhughes tomhughes deleted the xhr branch July 5, 2018 07:20
@bhousel bhousel mentioned this pull request Jul 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomhughes @bhousel