Add double-click locking of draw mode #5908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhatchl
commented
Feb 18, 2019
| @@ -76,6 +77,27 @@ export function uiModes(context) { | |||
|
|
|||
|
|
|||
| var debouncedUpdate = _debounce(update, 500, { leading: true, trailing: true }); | |||
| var debouncedClick = _debounce(clickModeButton, 300); | |||
There was a problem hiding this comment.
@quincylvania Not sure if a debounced function is the best way to support a click and a dblclick on an element, but it works for my click rate.
|
Thanks, @brianhatchl, I'll take a look! |
|
So at the moment we're targeting #5960 which will actually hide the mode buttons as soon as you enter the drawing mode. Double-clicking wouldn't be a viable interaction at that point, particularly for unlocking the mode. Alternatively we could have a lock button in the contextual UI. This is far more discoverable anyway and would work better on touchscreens.
|
|
Closing here, as @quincylvania said we're currently heading towards a contextual secondary menu that will include a lock button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5874