-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favorite preset #5914
Favorite preset #5914
Conversation
@quincylvania I didn't get the preset favorite/tag-reference buttons sharing the same vertical space figured out (my kung-fu for making fiddly css changes is lacking 😁). But I did get the favorite preset/modes wired up. It relies on changes to mode constructors that will hopefully pass muster. The favorites get written to local storage. This code is in the context because I needed access to the favorites from the favorite star button as well as the modes; and also needed to be able to fire an event when favorites change to trigger the modes update method. The preset favorites have a limit of 3 currently (no drop down at this point). I also rationalized that the tooltip could describe the geometry type bound to the favorite (instead of figuring out the icon geometry modifier). |
Thanks @brianhatchl! I'm working on fixes for the 2.14.2 point release right now. I'll take a look once things settle down! |
Tweak CSS classes
Don't show preset browser when adding a favorite point Don't automatically open the sidebar when selecting a non-new feature
Use first in, first out favoriting order
Don't show area midpoint dots on small preset icons
@brianhatchl I ended up tweaking a lot of little things like the icons and tooltips but the underlying code seems to do the trick. Thanks again! @bhousel I'm happy with this as an initial implementation. It could still use some polish as we build out #5882 and #5960 but I think we can merge it as soon as you can give it a look over. |
Further considerations:
|
This looks great! I took a quick look over the code and it all looks great 👍 Go ahead and merge it so people can start using it and we can collect some early feedback.. |
refs #5873