Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify API.md description for locale param #6005

Merged
merged 1 commit into from Mar 4, 2019
Merged

Clarify API.md description for locale param #6005

merged 1 commit into from Mar 4, 2019

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Mar 3, 2019

I tried to make the documentation a bit more specific since I ran into this at #5988.

Changes:

  • Highlight the different URL param-patterns (hash vs. regular)
  • Add an example with regional locale en-US
  • Add locale param to the list of osm-website-params with a bit more info about the different default-behavior there

This is a follow up to #5650 and based on the feedback in #5988. Thanks @quincylvania for 07327eb, btw.

@tordans
Clarify API.md description for locale param
b6b0026 
- Highlight the different URL param-patterns (hash vs. regular)
- Add an example with regional locale `en-US`
- Add `locale` param to the list of osm-website-params with a bit more info about the different default-behavior there

This is a follow up to #5650 and based on the feedback in #5988.
@bhousel
Copy link
Member

bhousel commented Mar 4, 2019

Thanks @tordans 👍

@bhousel bhousel merged commit 2646581 into openstreetmap:master Mar 4, 2019
@tordans tordans deleted the patch-5 branch July 20, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tordans @bhousel