Offer to connect sidewalk to service road without tagging crossing #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
May 25, 2023
| @@ -435,6 +441,10 @@ export function validationCrossingWays(context) { | |||
|
|
|||
| if (connectionTags) { | |||
| fixes.push(makeConnectWaysFix(this.data.connectionTags)); | |||
| let lessLikelyConnectionTags = tagsForConnectionNodeIfAllowed(entities[0], entities[1], graph, true); | |||
| if (lessLikelyConnectionTags && JSON.stringify(connectionTags) !== JSON.stringify(lessLikelyConnectionTags)) { | |||
There was a problem hiding this comment.
When a footway crosses a major road, it would be possible to offer a crossing=no connection as a less likely option. However, crossing=no doesn’t have a preset yet (openstreetmap/id-tagging-schema#548) and looks just like highway=crossing on the map, which could be confusing.
There was a problem hiding this comment.
offer a
crossing=noconnection
I agree that the tagging-schema would need to support this first in order to make sense. Let's keep that option in mind for a later stage.
tyrasd
approved these changes
May 25, 2023
| @@ -435,6 +441,10 @@ export function validationCrossingWays(context) { | |||
|
|
|||
| if (connectionTags) { | |||
| fixes.push(makeConnectWaysFix(this.data.connectionTags)); | |||
| let lessLikelyConnectionTags = tagsForConnectionNodeIfAllowed(entities[0], entities[1], graph, true); | |||
| if (lessLikelyConnectionTags && JSON.stringify(connectionTags) !== JSON.stringify(lessLikelyConnectionTags)) { | |||
There was a problem hiding this comment.
offer a
crossing=noconnection
I agree that the tagging-schema would need to support this first in order to make sense. Let's keep that option in mind for a later stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a driveway or other service road crosses a sidewalk, offer to either connect them without any tags or connect them with
highway=crossing. Previously, there was only one option that implied nothing about tags but addedhighway=crossinganyways:When a service road crosses an ordinary footpath, or when a larger road crosses a sidewalk, continue to offer just the option to connect them with
highway=crossing, but with the same icon as the crossing presets. Similarly, when a stream crosses a sidewalk, show the same icon as the Ford preset:Fixes #8463.