Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support no and "other" states of options of multiCombo/manyCombo fields #9656

Merged
merged 2 commits into from
May 25, 2023
Merged

support no and "other" states of options of multiCombo/manyCombo fields #9656

merged 2 commits into from
May 25, 2023

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented May 25, 2023 •
edited
Loading

For multiCombo and manyCombo fields: no values are not ignored anymore. Values are rendered with a checkbox which allows to toggle the states. Non yes/no values are rendered using a "undetermined" checkbox state, in which case the hover text shows the value of the tag.

example

female=no
male=unknown
unisex=yes

old:
image

new:
image

multiselection example

  • female=yes
male=no
unisex=no

  • female=no
male=yes
unisex=no

old:
image

new:
image

@tyrasd tyrasd added field An issue with a field in the user interface enhancement An enhancement to make an existing feature even better labels May 25, 2023
@tyrasd
don't repeat values from multi-selection in dropdown
28630ae 
as their state can now been toggled using the checkbox in the chip
@tyrasd tyrasd merged commit 28630ae into develop May 25, 2023
4 checks passed
@tyrasd tyrasd temporarily deployed to workflows May 25, 2023 16:50 — with GitHub Actions Inactive
@tyrasd tyrasd deleted the combo-yes-no-options branch May 25, 2023 16:50
@tyrasd tyrasd mentioned this pull request May 25, 2023
Closed
@tyrasd tyrasd added this to the 2.26 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement An enhancement to make an existing feature even better field An issue with a field in the user interface
Projects
None yet
Milestone
2.26
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tyrasd