Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering for roller_coaster=track and roller_coaster=support #9891

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Add rendering for roller_coaster=track and roller_coaster=support #9891

merged 2 commits into from
Dec 15, 2023

Conversation

mangerlahn
Copy link
Contributor

@mangerlahn mangerlahn commented Sep 7, 2023 •
edited
Loading

Closes #9839 by adding rendering to roller_coaster=track and roller_coaster=support.
Fits the preset PR and the rendering used in OpenStreetMap Carto.

I am a bit unsure on the rendering of the support beams. Are they being rendered too thick, is the contrast too low?

Before:
Screenshot 2023-09-07 at 14 36 15

After:
Screenshot 2023-09-07 at 14 35 47

@paganella31
Copy link

At this point in time both Carto and OsmAnd do render roller coasters, so it would be good to merge this PR.
Regarding the support beams, indeed they seem slightly thick to me. I would personally make them a little smaller.

@bhousel bhousel mentioned this pull request Dec 5, 2023
Closed
21 tasks
bhousel added a commit to facebook/Rapid that referenced this pull request Dec 5, 2023
@bhousel
Support Roller Coaster presets and rendering
535adbe 
re: #1219
re: openstreetmap/iD#9891
re: openstreetmap/id-tagging-schema#985
@tyrasd tyrasd added the map-renderer An issue with how things are rendered in the map label Dec 15, 2023
@tyrasd tyrasd merged commit 5c7432b into openstreetmap:develop Dec 15, 2023
3 checks passed
@tyrasd tyrasd mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rendering for roller_coaster=track
3 participants
@mangerlahn @paganella31 @tyrasd