Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields/kerb: Make directionalCombo to allow optional left/right tagging #1206

Closed
wants to merge 1 commit into from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Apr 28, 2024

When the kerb is tagged on the highway=crossing node, it is assumed to have the same kerb left an right of the node. If that is not true, the tagging is kerb:left|right=*.

This PR changes the kerb fields for crossings to a directionalCombo in order to represent those left|right cases.

Current usage:

  • crossing=* has 340 208 cases with kerb
  • 2 690 with kerb:right
  • 2 660 with kerb:left

https://taginfo.openstreetmap.org/keys/crossing#combinations

@tordans tordans mentioned this pull request Apr 28, 2024
18 tasks
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator Author

tordans commented Apr 28, 2024

Testing

Overpass turbo query: https://overpass-turbo.eu/?R&Q=[out:json][timeout:25];node["highway"]["kerb:left"]({{bbox}});out body;>;out skel qt;

node/9165437876

image

@tordans
Copy link
Collaborator Author

tordans commented Apr 28, 2024

Conclusion

Looking at the numbers some more I don't think this added complexity in the UI is worth it.
I will close this PR for that reason.

@tordans tordans closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant