Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset and field for sport=table_football #485

Merged
merged 5 commits into from
Jun 17, 2022

Conversation

Binnette
Copy link
Contributor

@Binnette Binnette commented Jun 1, 2022

Hi, here is a proposition for https://wiki.openstreetmap.org/wiki/Tag:sport=table_soccer

But DO NOT MERGE IT yet. Cause I created it as a preset of leisure=pitch BUT the wiki do not say it should be "combined" with leisure=pitch. It seems this tag sport=soccer can be "alone" on a node without any other tag.

Can you please tell me how we should add it in the id-tagging-schema?

@westnordost
Copy link
Contributor

westnordost commented Jun 1, 2022

I've read the wiki article. The tag is meant to be added as a field to amenities like pubs etc. to indicate that it has a table soccer table (the same being possible for darts, 9pin, billiard or whatever else can be played at that pub)

leisure=pitch + sport=table_soccer would only make sense if one wanted to map a single outdoor table soccer table. I have not seen in my life an outdoor table soccer table, I don't think this is a thing. But if there was such a thing, that would be the tag to use.

So what you would want to add is a field for the pub preset. (Can't offer assistance of how to do that because I don't know, better look at other fields to see how it is done).

@Binnette
Copy link
Contributor Author

Binnette commented Jun 2, 2022

Hi @westnordost thanks for your comments. Note that my PR addess this issue OsmTravel/OsmGo#108:

I found quite a few table soccer tables in public parks (foosball, "babyfoot" in French), but the lack of a preset tag on Osm Go! makes it harder to tag them. I think the table tennis preset could be used, with "Lit" and "Access".

In this issue, @maroneze report table soccer directly in parks as a POI (so out of amenities, pub, etc). So @maroneze will more than probably map then directly as a node on the map.

Please let me know your point of view @westnordost 👍

@maroneze
Copy link

maroneze commented Jun 2, 2022

I have not seen in my life an outdoor table soccer table, I don't think this is a thing. But if there was such a thing, that would be the tag to use.

I had never seen it either (and I thought it unwise due to rain), but apparently that's a thing in some French towns (I've seen at least 3 in nearby towns). I didn't think of taking a photo (I will try to do it to submit it to the OSM wiki eventually), but if you google "babyfoot table parc" in Google Images ('babyfoot' is the French term for table soccer), you can hopefully see a few examples. Some companies sell them directly to town councils who want to refurbish parks.

@tordans
Copy link
Collaborator

tordans commented Jun 2, 2022

JFYI, we have them in our hood.

Mapped by @SupaplexOSM

leisure	pitch
sport	table_soccer

Mapped by me

playground	tabletop_football

@Hufkratzer
Copy link
Contributor

I have not seen in my life an outdoor table soccer table, I don't think this is a thing.

Table soccer tables can of course also be mapped if they are indoors, like other kinds of pitches too. "indoor=yes" may be added in these cases, example https://www.openstreetmap.org/node/9551800192

@tyrasd tyrasd marked this pull request as draft June 8, 2022 10:37
@tyrasd
Copy link
Member

tyrasd commented Jun 8, 2022

Currently, the tag is used surprisingly rarely: of the ~300 features which have the tag, around half to two thirds seem to be amenity features like pubs (which would benefit from an added field) and the rest seems to be individually mapped table soccer tables (which would benefit from a new preset).

These raw usage numbers wouldn't currently warrant the inclusion as a preset/field, but I would also assume that table soccer tables are quite significantly more common in real life compared what is currently mapped. Therefore, I would not object adding this tag as a preset and/or field.

For a field, it would probably be needed to use a semiCombo field type for the sport key and allow related "pub" sports like billiards, darts, etc. (you can use https://github.com/openstreetmap/id-tagging-schema/blob/v3.3.0/data/fields/sport_ice.json as a template).

@Binnette
Copy link
Contributor Author

Hi @tyrasd, please let me know how I should amend my PR 👍

@tyrasd
Copy link
Member

tyrasd commented Jun 13, 2022

Hi @tyrasd, please let me know how I should amend my PR +1

Could you please, in addition to the already created new preset, also add a new field called sport_pub.json? For tht you can use sport_ice.json as a template, but replace the options list with table_soccer, billiards and darts. Then, add this new field as an optional field (moreFields) to the presets mentioned on the wiki: pub, bar, restaurant.

@Binnette
Copy link
Contributor Author

TY @tyrasd, i just pushed the requested changes. Can you please review them 👍

@tyrasd tyrasd marked this pull request as ready for review June 14, 2022 19:51
@tyrasd
Copy link
Member

tyrasd commented Jun 14, 2022

Looks good to me, thanks! 👍 I only changed the preset's name to Table Football Table. The double table sounds a bit funny, but I guess it is acceptable. Is that ok for you?

@Binnette
Copy link
Contributor Author

Hi @tyrasd I'm not a native english speaker, so I usually trust wikipedia to translate from french.

Table football, also called foosball and table soccer, is a table-top game...

Source: https://en.wikipedia.org/wiki/Table_football

@arch0345
Copy link
Contributor

I think that this should be named Foosball Table instead of Table Football Table since this game is commonly called foosball in American English. Table Football should instead be used for the English (United Kingdom) locale.

For example, Amazon in the US refers to this game as 'foosball' while Amazon.co.uk calls this game 'table football':

Screenshot 2022-06-15 220908
Screenshot 2022-06-15 221221

@Binnette
Copy link
Contributor Author

So we just revert to "Table football" and we can merge?

@tyrasd tyrasd changed the title Add table_soccer - DO NOT MERGE YET Add preset and field for sport=table_football Jun 17, 2022
@tyrasd tyrasd merged commit 1f86904 into openstreetmap:main Jun 17, 2022
@tyrasd
Copy link
Member

tyrasd commented Jun 17, 2022

Merged with "Foosball Table" as the preset's name and field value.

PS: I just noticed that there is no icon for the preset, but it's also not easy to find something that fits. There isn't really anything on maki, temaki and not even fontawesome when searching in fontawesome's collection). Svgrepo (see ideditor/schema-builder#60) would have one, but it's too detailed for the size we would display it at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants