Drop last vestiges of ruby 2.5 support

.github/workflows/tests.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         ubuntu: [18.04, 20.04]
-        ruby: [2.5, 2.7, 3.0]
+        ruby: [2.7, 3.0]
     runs-on: ubuntu-${{ matrix.ubuntu }}
     env:
       RAILS_ENV: test

.rubocop.yml

@@ -7,7 +7,7 @@ require:
   - rubocop-rake
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
   NewCops: enable
   Exclude:
     - 'vendor/**/*'

app/helpers/user_roles_helper.rb

@@ -1,6 +1,6 @@
 module UserRolesHelper
   def role_icons(user)
-    safe_join(UserRole::ALL_ROLES.collect { |role| role_icon(user, role) }.compact, " ")
+    safe_join(UserRole::ALL_ROLES.filter_map { |role| role_icon(user, role) }, " ")
   end
 
   def role_icon(user, role)

config/initializers/oauth.rb

@@ -16,7 +16,7 @@ def escape(value)
 
     def unescape(value)
       value.to_s.gsub(/%\h{2}/) do |c|
-        c[1..-1].to_i(16).chr
+        c[1..].to_i(16).chr
       end.force_encoding(Encoding::UTF_8)
     end
   end
@@ -52,12 +52,12 @@ def render(options = {})
     module ClassMethods
       def included(controller)
         controller.class_eval do
-          def self.before_filter(*names, &blk)
-            before_action(*names, &blk)
+          def self.before_filter(...)
+            before_action(...)
           end
 
-          def self.skip_before_filter(*names, &blk)
-            skip_before_action(*names, &blk)
+          def self.skip_before_filter(...)
+            skip_before_action(...)
           end
         end
 

lib/id.rb

@@ -1,3 +1,3 @@
 module ID
-  LOCALES = Locale.list(Rails.root.join("vendor/assets/iD/iD/locales").entries.map { |p| p.basename.to_s[/(.*).json/] && Regexp.last_match(1) }.compact)
+  LOCALES = Locale.list(Rails.root.join("vendor/assets/iD/iD/locales").entries.filter_map { |p| p.basename.to_s[/(.*).json/] && Regexp.last_match(1) })
 end