Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure redaction text does not go off of page #1845

Closed
gravitystorm opened this issue May 3, 2018 · 9 comments
Closed

Ensure redaction text does not go off of page #1845

gravitystorm opened this issue May 3, 2018 · 9 comments
Labels
good first issue Issues that require little knowledge of the codebase

Comments

@gravitystorm
Copy link
Collaborator

The redaction text at https://www.openstreetmap.org/redactions/101 doesn't wrap, and so it makes the page super-wide. I don't think there's any reason to avoid wrapping here, even in pre-formatted blocks.

If there is some reason to prevent wrapping, then the block should be scrollable but the page width otherwise unaffected.

@gravitystorm gravitystorm added the good first issue Issues that require little knowledge of the codebase label May 16, 2018
@robotscissors
Copy link
Contributor

I would like to work on this issue. I am new to open source contributions.

@pnorman
Copy link
Contributor

pnorman commented May 27, 2018

I edited the redaction so it's no longer causing this particular page to go extra-wide, but the root cause should still be fixed.

It's also worth checking what other markdown-using pages (diaries, messages, etc) on the site do for wide pre-formatted blocks.

@robotscissors
Copy link
Contributor

It looks like you applied some CSS and popped the code into a container. I figured that was going to be my approach. If you agree, I will take a look at the other markdown pages as you suggested.

@pnorman
Copy link
Contributor

pnorman commented May 27, 2018

I didn't change any CSS, I just edited the text of the message.

@robotscissors
Copy link
Contributor

Understood. Let me look at your solution and see if it needs to be applied elsewhere.

@pnorman
Copy link
Contributor

pnorman commented May 28, 2018

I didn't have a solution, I edited the markdown of the redaction. No code was changed. Other redactions with a long line in a markdown code block would have the same problem.

@robotscissors
Copy link
Contributor

@pnorman HI Paul, I am a newbie and this is a huge application, so forgive me.

I am having trouble recreating the issue in my current environment. He is what I have done.

  • I installed the application locally and was able to see the website at localhost:3000.
  • I created an account for myself and validated it through an email link that was displayed on the server.
  • I created a diary entry with a long string using markdown `` to encapsulate the entire message for the worst case, but it wrapped just fine.

Any other hints to recreate the issue in the development environment.

@pnorman
Copy link
Contributor

pnorman commented May 28, 2018

You need to give yourself the "moderator" flag and then go to /redactions/new and create a new redaction. The one originally linked in this issue used four spaces in front of a long line to format it as code.

@robotscissors
Copy link
Contributor

robotscissors commented May 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that require little knowledge of the codebase
Projects
None yet
Development

No branches or pull requests

3 participants