Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for tracepoint ordering #2059

Open
gravitystorm opened this issue Nov 14, 2018 · 1 comment
Open

Tests for tracepoint ordering #2059

gravitystorm opened this issue Nov 14, 2018 · 1 comment

Comments

@gravitystorm
Copy link
Collaborator

cdb42d2 was a hotfix for an important privacy problem, but hasn't yet received any tests.

I would also recommend refactoring the complex logic out of the controller and into the TracePoint model, which will make it easier to test too.
krubokrubo added a commit to krubokrubo/openstreetmap-website that referenced this issue Nov 19, 2018
@krubokrubo
Move tracepoint ordering logic into tracepoint model, and add tests
a154207 
Closes openstreetmap#2059
@krubokrubo krubokrubo mentioned this issue Nov 19, 2018
Open
@krubokrubo
Copy link
Contributor

I submitted a pull request for this. I kept the logic exactly as it was, although I'm still a bit doubtful about the meaning of the different visibility values (private/public/trackable/identifiable). Let me know if it's suitable?

krubokrubo added a commit to krubokrubo/openstreetmap-website that referenced this issue Nov 20, 2018
@krubokrubo
Move tracepoint ordering logic into tracepoint model as scopes
f6e1437 
The controller still does the union of trackable ordered points
with non-trackable unordered points, getting each from the model.
Closes openstreetmap#2059
krubokrubo added a commit to krubokrubo/openstreetmap-website that referenced this issue Nov 20, 2018
@krubokrubo
Move tracepoint ordering logic into tracepoint model as scopes
ad61878 
The controller still does the union of trackable ordered points
with non-trackable unordered points, getting each from the model.
Closes openstreetmap#2059
krubokrubo added a commit to krubokrubo/openstreetmap-website that referenced this issue Nov 20, 2018
@krubokrubo
Move tracepoint ordering logic into tracepoint model as scopes
a5ca1c7 
The controller still does the union of trackable ordered points
with non-trackable unordered points, getting each from the model.
Closes openstreetmap#2059
krubokrubo added a commit to krubokrubo/openstreetmap-website that referenced this issue Nov 21, 2018
@krubokrubo
Move tracepoint ordering logic into tracepoint model as scopes
9f6e852 
The controller uses these scopes to do the union of trackable (and
identifiable) points with anonymized private (and public) points.
Closes openstreetmap#2059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gravitystorm @krubokrubo