Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for multiple gpx files in archives #2254

Closed
gravitystorm opened this issue Jun 11, 2019 · 1 comment
Closed

Add tests for multiple gpx files in archives #2254

gravitystorm opened this issue Jun 11, 2019 · 1 comment

Comments

@gravitystorm
Copy link
Collaborator

This was fixed in ee458b6 , but since it was a hotfix it didn't contain tests. We should add some tests to prevent the same problem from happening again in the future, and so I'm adding this ticket in order that we don't forget.

@tomhughes
Copy link
Member

Yeah that was already on my to do list ;-)

It proved a bit more complicated than I would have liked because both the libarchive wrapper and the zlib reader are doing the file access directly from C and bypassing FakeFS so we have to partially work on the real filesystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants