Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember me: be more forthcoming about how many days #2457

Closed
jidanni opened this issue Dec 8, 2019 · 16 comments
Closed

Remember me: be more forthcoming about how many days #2457

jidanni opened this issue Dec 8, 2019 · 16 comments

Comments

@jidanni
Copy link

jidanni commented Dec 8, 2019

On the login page there is a checkbox "[ ] Remember me".

OK but for how many days is a big secret.

Add a mouseover saying for how many days.

If the user knew it was supposed to remember for X days, but it didn't, then he could report a bug with confidence it was a bug.

@jidanni
Copy link
Author

jidanni commented Dec 8, 2019

Else with no clarification, it means "remember me forever".

@jidanni
Copy link
Author

jidanni commented Dec 8, 2019

One finds a cookie, _osm_session
Created Sunday, December 8, 2019 at 7:36:15 PM
Expires Sunday, January 5, 2020 at 7:48:20 PM
Therefore the mouseover should say "Remembers you for four weeks."

@jidanni
Copy link
Author

jidanni commented Dec 8, 2019

So apparently, even if one opens their browser every day and browses the site, after the four weeks are up, one will find oneself suddenly logged out, perhaps. Anyway all this should be made clear in the mouseover, or nearby help button.

@jidanni
Copy link
Author

jidanni commented Dec 8, 2019

As this is Openstreetmap, one would expect all this to be out in the open.

@tomhughes
Copy link
Member

I think it's actually broken. I think originally it was four weeks from the last time you used the site but the refresh of the expiry seems to have got lost and it is now four weeks from login.

@kymckay
Copy link

kymckay commented Dec 8, 2019

I can confirm that lately I've been getting logged out frequently with this checked (weirdly after even less than four weeks).

@tomhughes
Copy link
Member

That is not related. I suspect that we're starting to run low on memory in the memcache store which will cause sessions to be evicted.

@jidanni
Copy link
Author

jidanni commented Dec 9, 2019

@tomhughes: van you please turn my notifications back on. I am only getting notified about other peoples' comments, not yours.

@gravitystorm
Copy link
Collaborator

That is not related. I suspect that we're starting to run low on memory in the memcache store which will cause sessions to be evicted.

Is there anything we can do in this repo? Or should we move the ticket to operations?

@jidanni
Copy link
Author

jidanni commented Jan 20, 2021

I can confirm that lately I've been getting logged out frequently with this checked (weirdly after even less than four weeks).

Now it seems down to about a couple of days! Getting less and less. Certainly some cache is getting filled up. Wish TomHughes could help.

@tbertels
Copy link

That is not related. I suspect that we're starting to run low on memory in the memcache store which will cause sessions to be evicted.

So the session keys aren't saved in the DB, only in memory?

@tomhughes
Copy link
Member

Correct, the production system uses memcache for sessions so the session data is not in the database.

@mmd-osm
Copy link
Collaborator

mmd-osm commented Jun 22, 2024

I think this is not actionable in this repo. In case there's still a need to bump the memcache size, please create a new issue on the operations repo instead: https://github.com/openstreetmap/operations

@mmd-osm mmd-osm closed this as completed Jun 22, 2024
@jidanni
Copy link
Author

jidanni commented Jun 27, 2024

Thanks, but which
https://github.com/openstreetmap/operations/issues/new/choose
category should I use?

@mmd-osm
Copy link
Collaborator

mmd-osm commented Jun 27, 2024

„Open a blank issue.“
(That’s a link somewhere at the bottom)

@jidanni
Copy link
Author

jidanni commented Jul 5, 2024

OK but there they say:

I definitely see the issue that you are referring to but I am unable it as all evidence says it shouldn't be down to memcache.

So maybe I should just be happy with however many days it remembers and give up trying to get it stabilized.

Odd, on wiki.openstreetmap.org one seems to stay logged in for years and years, but on openstreetmap.org it's just a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants