Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot post UTF-8 chars in comments to notes and changesets #3184

Closed
Zverik opened this issue Apr 26, 2021 · 5 comments
Closed

Cannot post UTF-8 chars in comments to notes and changesets #3184

Zverik opened this issue Apr 26, 2021 · 5 comments

Comments

@Zverik
Copy link
Contributor

Zverik commented Apr 26, 2021

See https://github.com/openstreetmap/operations/issues/524

For example, If I go to https://www.openstreetmap.org/note/2639402 and try to comment with "test with ccaron č letter" I get 401 Unauthorized. Same if it contains other national letters like "ČĆŠĐŽ". If I use just plain US-ASCII, it works fine.

Probably related to ad6c0d3 as @mmd-osm found.

@mmd-osm
Copy link
Contributor

mmd-osm commented Apr 26, 2021

Issue is triggered as a side effect of ad6c0d3 - reverting this commit fixes the issue in a local test.

Affected: Some endpoints which are being handled by the Rails port, when using OAuth1.0a authentication.

@matkoniecz
Copy link
Contributor

It also causes notes to be created as anonymous user despite being logged in: https://www.openstreetmap.org/note/2639681 vs https://www.openstreetmap.org/note/2639682

@tomhughes
Copy link
Member

tomhughes commented Apr 26, 2021

Duplicate of #3185.

@Zverik
Copy link
Contributor Author

Zverik commented Apr 26, 2021

but this is 3184...

@tomhughes
Copy link
Member

Yes but the other one was raised earlier, just in the wrong place and I didn't realise until I wondered why a new ticket had been entered s I moved it over here which gave it a new higher number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants