No scroll bar for editing lengthy diary entries

[skorasaurus]

There's no scroll bar on the text bar/body when editing diary entries.

You can expand the text box horizontally by dragging the bottom right hand corner, but then the markdown syntax box remains in position and you still can't scroll vertically.

Tested on FF 22 and chrome 28.0.1500.68, both on ubuntu 12.04

[tomhughes]

The real problem here is that the auto growing of the text area has stopped working, most likely as a result of @samanpwbb's recent redesign work.

[tomhughes]

The problem is https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/stylesheets/common.css.scss#L1537 which sets the height of text areas to 100% with the !important flag, so it overrides the dynamically determined height which the auto grow plugin sets.

That line came in with c3b8897.

[seav]

This issue also affects the textbox for sending messages. And likely other textboxes as well such as commenting on a diary entry.

Furthermore, if you try to scroll using the mouse/trackpad over the textbox (if there's overflowing text), the web page scrolls instead of the textbox.

FWIW, the textboxes here in Github work wonderfully and is worth emulating.

[tomhughes]

Yes, it will affect all text boxes, and emulating github is basically what the autogrow code does if it wasn't being usurped by the !important rule in the style sheet.

[openstreetmap-website]

I suggest we eliminate the auto-grow plugin. It's unpredictable and it's
not that helpful. A reasonable-sized text form + standard overflow is
better.

On Sun, Jul 14, 2013 at 11:53 AM, Tom Hughes notifications@github.comwrote:

Yes, it will affect all text boxes, and emulating github is basically what
the autogrow code does if it wasn't being usurped by the !important rule
in the style sheet.

—

Reply to this email directly or view it on GitHubhttps://github.com//issues/330#issuecomment-20938333
.

---

rails-dev mailing list
rails-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/rails-dev

[tomhughes]

...and who are you exactly? Please don't reply by email to github notifications on the rails-dev list as it impossible to tell who you are if you do that.

[samanpwbb]

@tomhughes oh, I thought I was responding to the github notification directed at me (which would have posted under my account. That was me.

[tomhughes]

No problem. I'm happy to drop it if people think that's the best idea.

[tomhughes]

Remove autogrow in fe2f03d.