Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field to notes to indicate what software is creating them #385

Open
ToeBee opened this issue Jul 28, 2013 · 5 comments
Open

Add a field to notes to indicate what software is creating them #385

ToeBee opened this issue Jul 28, 2013 · 5 comments
Labels
notes Related to the notes feature

Comments

@ToeBee
Copy link
Contributor

ToeBee commented Jul 28, 2013

As more apps and external entities like Craigslist start using our "Notes" feature, it would be helpful to see where notes are coming from.

For example if they come from Craigslist, I know that the user was looking at a custom rendering that may be several weeks out of date. If it is from a smartphone app it means the user was probably in the field and had eyes on the situation when the note was created. If it was created in JOSM then it is likely an armchair mapper making a note of something he didn't have time to fix up while doing some other mapping.

Basically I want a "created_by" tag for notes just like changesets have now. Obviously notes don't have tags and I don't see much use in allowing arbitrary tagging on notes so it should just be its own field.

@tomhughes
Copy link
Member

We did discuss this at EWG a few weeks back, but I can't remember what the plan was beyond the fact that @zerebubuth wasn't impressed with my plan to leverage the oauth clients ;-)

There should be something in the minutes though.

@pnorman
Copy link
Contributor

pnorman commented Jul 28, 2013

relevant meeting was http://www.osmfoundation.org/wiki/Working_Group_Minutes/EWG_2013-06-17

17:54:04 <zere> although i guess if it's tied to an oauth client ID then it's not going to change with the versions (people won't want to have to re-auth a new client for each version bump), and isn't havign the version information very useful?
17:55:19 <TomH> I guess that's a good point
17:56:25 <zere> although easy enough to ask for a key and a version number (smallint or something). probably not a big deal, but an opaque string is easier for the app dev.
17:56:55 <zere> perhaps having a client_strings table which is just a map<int, string> to uniquify the strings?
17:57:38 <TomH> could do... I'll think about it some more
17:57:56 <zere> cool.

@westnordost
Copy link

If this is simply about identifying with which user agent the user created or commented the note, why not simply use the UserAgent from the HTTP header?

@peternewman
Copy link

If this is simply about identifying with which user agent the user created or commented the note, why not simply use the UserAgent from the HTTP header?

That wouldn't differentiate between Craigslist and the OSM website and the OSM website on a browser in the field though would it, unless you also included the referrer or something?

@andrewharvey
Copy link
Contributor

This would help with streetcomplete/StreetComplete#2692 (comment) but in general it's very useful for mappers to know if the note came from a survey app, or website. Right now some apps embed this content within the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes Related to the notes feature
Projects
None yet
Development

No branches or pull requests

7 participants