URL/body are wrong after invalid form submission

[samanpwbb]

Is this just on my local build of OSM or is this a real problem?

The content inside body is correct, but:

• Body class should be user user-new not user user-terms
• URL should be /user/new not /user/terms

[tomhughes]

Hmm.... It's not wrong as such, it's just an odd side effect of the way the signup works...

The initial form is /user/new but when you submit it posts to /user/terms which would normally then display the terms page, but if there is a validation error it renders the new view again, but of course the action is still terms so that is the class which gets assigned...

[jfirebaugh]

The typical Rails pattern would be to POST to /user/new, which redirects to /user/terms on success.

[tomhughes]

Sure - the problem is making sure we somehow preserve enough state, because we need to remember all the form data from the first page until we are ready to create the user record, which only happens after the terms have been accepted.

Currently that works via hidden parameters on the terms page I think.

[tomhughes]

Actually it looks like we create the record and save it in the session now, and only save it to disk at the very end, so we can probably rearrange this fairly easily.

[samanpwbb]

This is causing so e problems for me when trying to do things based on body classes. I can stop relying on body classes if this is a difficult problem to fix.

[jfirebaugh]

@tomhughes Are you working on this? Otherwise I can take it.

[tomhughes]

@jfire Feel free to have a go at it - it's all a bit messy though I'm afraid...

[tomhughes]

Fixed by merging #405.