Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain editor/location URL parameters throughout user signup #400

Closed
samanpwbb opened this issue Jul 30, 2013 · 5 comments
Closed

Retain editor/location URL parameters throughout user signup #400

samanpwbb opened this issue Jul 30, 2013 · 5 comments

Comments

@samanpwbb
Copy link
Member

Right now,

We encode information about which editor you're using + your location in URLS. If I'm in Washington, DC in iD I get this URL:

http://www.openstreetmap.org/edit?editor=id&lat=42.80866&lon=-87.94369&zoom=15

If I share this with a logged-in user, they'll be able to jump right into iD in that area. Pretty cool.

If I share it with a user who isn't logged in, the parameters in the URL are retained throughout the login process, but then we lose them once the user goes through e-mail confirmation. Cam we retain the URL parameters in the e-mail, and send the user to the destination encoded in the URL once they've truly finished the login process?

@tomhughes
Copy link
Member

That shouldn't happen - the referer information is preserved as part of the token and retrieved when the account is confirmed and redirected to. At least that is what is supposed to happen.

@lxbarth
Copy link
Contributor

lxbarth commented Jul 31, 2013

If I share it with a user who isn't logged in, the parameters in the URL are retained throughout the login process, but then we lose them once the user goes through e-mail confirmation.

I can confirm this on

http://welcome.apis.dev.openstreetmap.org/

@jfirebaugh
Copy link
Member

This is probably due to some of my changes on the welcome branch -- I changed it to unconditionally redirect to /welcome after confirmation.

@jfirebaugh
Copy link
Member

This will be fixed in #338, can close here.

@tomhughes
Copy link
Member

Fixed by the merge of #338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants