Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar_content div too tall (scrollbar not completely visible) #500

Closed
ppawel opened this issue Oct 2, 2013 · 1 comment
Closed

sidebar_content div too tall (scrollbar not completely visible) #500

ppawel opened this issue Oct 2, 2013 · 1 comment

Comments

@ppawel
Copy link
Contributor

ppawel commented Oct 2, 2013

I've been merging master into my owl-history-tab branch and I noticed that there were some changes in the sidebar markup and CSS and now there's a problem when sidebar contents overflow and need to be scrolled.

Take a look:

http://owl.apis.dev.openstreetmap.org/#map=12/50.0464/19.9982

(click History tab)

You will see that sidebar heading has ~30px of height and then comes sidebar content div which has height: 100% but I guess it is 100% of the whole sidebar not of the remaining space below the heading so it goes off screen at the bottom.

I tried to fix it but I suck at CSS, the only solution I manage to get working was to change sidebar_heading and sidebar_content to absolute positioning and set bottom: 0px for sidebar_content but I guess that's not the "right" solution?

@tomhughes
Copy link
Member

The existing sidebar implementation no longer exists now the redesign branch has been merged, so this is now redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants