Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD doesn't support IE, but IE11 doesn't contain MSIE in user agent. #515

Closed
EdLoach opened this issue Oct 22, 2013 · 5 comments
Closed

iD doesn't support IE, but IE11 doesn't contain MSIE in user agent. #515

EdLoach opened this issue Oct 22, 2013 · 5 comments

Comments

@EdLoach
Copy link

EdLoach commented Oct 22, 2013

IE11 (from my computer) reports "Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko" as User Agent at http://www.whatsmyuseragent.com

Line 434 of application_controller.rb at http://git.openstreetmap.org/rails.git/blob/HEAD:/app/controllers/application_controller.rb
is only checking for MSIE in the UserAgent. I'm guessing it needs an extra check.

See also issue openstreetmap/iD#1908

And perhaps see
http://blogs.msdn.com/b/ieinternals/archive/2013/09/21/internet-explorer-11-user-agent-string-ua-string-sniffing-compatibility-with-gecko-webkit.aspx

@tomhughes
Copy link
Member

Is IE11 not good enough to run iD anyway?

@EdLoach
Copy link
Author

EdLoach commented Oct 22, 2013

For whatever reason, the icons don't show (as per the issue I raised on the iD github). Otherwise I got most of the way through the training bit before that caused an issue.

@tomhughes
Copy link
Member

Is this sill an issue with the latest iD?

@jfirebaugh
Copy link
Member

Yes, still an issue.

@tomhughes
Copy link
Member

OK. I've pushed 49a4efc to block "Trident" as well as "MSIE".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants