Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display a box at all if the note event doesn't include a comment #1432

Conversation

saintamh
Copy link

@saintamh saintamh commented Feb 8, 2017

This fixes the bug reported in this comment on PR #1401

…t body

Before this it just displays en empty box, which looks wrong.
@tomhughes
Copy link
Member

Is there any point sending an email if there is no body? Why are we even allowing comments with no body?

@tomhughes
Copy link
Member

Oh this is notes not changeset comments, so it's probably normal when a note is closed?

@saintamh
Copy link
Author

saintamh commented Feb 8, 2017

Yes exactly, so if you close a note you can choose not to add a comment, and when you reopen a note you don't even have that option and there's never a comment. In both cases I think it's better to just not display a message box at all.

For other notification mails that have a message box (changeset comment, diary comment, direct message), an empty message would be odd on the part of the sender, and we can just carry that oddity across by leaving in the empty message box, I think.

@tomhughes tomhughes merged commit 448a684 into openstreetmap:master Feb 8, 2017
@saintamh saintamh deleted the fix-empty-message-box-on-note-comment branch February 8, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants