Wrap the permission label with a <label> tag

[EdwardBetts]

Gives the user a larger target to toggle a permission.

[tomhughes]

Can you explain what you mean? How does that create a larger target exactly? What is the effect on the rendering of this change?

[EdwardBetts]

Currently the user has to click the check box to toggle the option, with this change they can also click the label. The HTML changes to look like this:

<li><input type="checkbox" name="allow_read_prefs" id="allow_read_prefs" value="yes" checked="checked" /><label for="allow_read_prefs">read your user preferences.</label></li>

[gravitystorm]

Thanks @EdwardBetts ! This fixes a pet peeve of mine. There's lots more situations like this throughout the codebase, a simple search of app/views shows lots of label tags that aren't associated with any form fields. Even the ones that have "for" attributes are often wrong - e.g. app/views/user/new.html.erb where none of the label "for" attributes match the id of the form field. If you get the chance, fixing some of these, and moving them to rails tag helpers, would be appreciated too!