Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full url escaping when required in trace tests #1983

Merged
merged 1 commit into from Sep 10, 2018
Merged

Use full url escaping when required in trace tests #1983

merged 1 commit into from Sep 10, 2018

Conversation

gravitystorm
Copy link
Collaborator

The same approach is used elsewhere in the test suite.

@tomhughes
Copy link
Member

I did what I did because none of the recommended routines worked - originally I used URI.escape but rubylint told me that was deprecated and none of the alternatives it suggested actually worked right for what we needed...

@tomhughes tomhughes merged commit a8ecb1b into openstreetmap:master Sep 10, 2018
@gravitystorm gravitystorm deleted the display-name-url-tests branch October 3, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gravitystorm @tomhughes