Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum changeset size in pixels #2018

Merged

Conversation

jguthrie100
Copy link
Contributor

Changed the minimum changeset width to be in pixels rather than degrees.

When zooming out, the minimum pixel width is maintained, so even when max-zoomed out, the pixel width will be 40px (width could be easily edited)

@jguthrie100
Copy link
Contributor Author

jguthrie100 commented Oct 6, 2018

image

image

image

image

To be honest, I'm not sure if its an improvement or not. It seems a bit unintuitive when zoomed out

@jguthrie100
Copy link
Contributor Author

jguthrie100 commented Oct 7, 2018

image

Its not so bad at distance actually when you consider how small the different changesets across a wider area would be

@jguthrie100
Copy link
Contributor Author

jguthrie100 commented Oct 7, 2018

Actually, I take it back. There is a considerable improvement to the current implementation which shows just tiny dots, even at relatively close distances!

image

@tomhughes tomhughes merged commit 31c4461 into openstreetmap:master Oct 11, 2018
@uswoods
Copy link

uswoods commented Oct 16, 2018

To be honest, I'm not sure if its an improvement or not. It seems a bit unintuitive when zoomed out.

Indeed, sir! You should better revert this change.

@tomhughes
Copy link
Member

I wasn't aware that two people in a forum thread were "the community". Is there anything else they'd like a veto on?

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Oct 17, 2018

To be honest, I'm not sure if its an improvement or not. It seems a bit unintuitive when zoomed out.

Indeed, sir! You should better revert this change.

I really like the effect even while zooming. Perhaps my edits are "unusual". Can someone point me to a profile where the min-size is ugly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants