Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Friend into Friendships #2269

Merged
merged 4 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@gravitystorm
Copy link
Collaborator

commented Jun 19, 2019

This PR refactors the Friend model and related code, primarily by renaming it to Friendship to more accurately describe the model.

This also allows us to remove some naming gymnastics, so that user.friends is now a list of user objects.

I haven't actually renamed the database table, since that's a ton more work 馃槃

gravitystorm added some commits Jun 19, 2019

Rename Friend model to Friendship
This better describes what the model represents, which is the relationship
between the two users.
Rename user.friend_users to user.friends
This is possible now since we've renamed Friend to Friendship

@tomhughes tomhughes merged commit cbb3c2b into openstreetmap:master Jun 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 88.219%
Details

@gravitystorm gravitystorm deleted the gravitystorm:friendships branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.