W3C Geolocation added to user account settings page #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… click on the name of the nearby mapper in the map on the user page.
Conflicts: app/assets/javascripts/map.js.erb
|
I think you really need to rebase this without all the extra commits, as it's very hard to see what's going on at the moment. You should be able to do it with Then use |
When infer_extension is not set ActionCachePath does not set the extension from any explicitly specified format, and hence expiry produces cache keys which don't have any extension and don't match the keys generated when the cache entry was created.
The ways_for_node method on the way controller does not guarantee to return nodes in any particular order so we shouldn't rely on it doing so in our tests.
This reverts commit ccd7882.
This removes the whitespace in the url, and makes the root path a named route so that it can be nicely referenced.
This is a mild restyling of OpenStreetMap. Changes include: * Remove margin from map, add more margin to text content * Rearrange permalink & link buttons and gives them a background * Pull OpenStreetMap text below logo along with subtitle * Simplify sidebar styling * Move towards a baseline, start to consolidate text size and line height This is tested with LTR, RTL, and the compact mode, and looks good. Looks more uniform in older browsers because it relies less on round corners.
Adjusting the position of the map can impact the apparent size of the content area, so make sure we read that before we start making any changes to the position and size of the map.
Move font sizes and line heights up in the stylesheet structure to make the left element more uniform. Make the padding of the menu the same as the other elements.
This reverts commit 101ee6a.
danstowell
pushed a commit
to danstowell/openstreetmap-website
that referenced
this pull request
Jan 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added W3C Geolocation functionality to the user location map on the account settings page. This attempts to find a coarse location if the user has no home location set, so as to make setting the home location easier. If the location is already set, the map can be manually centered on the approx location by clicking a link on top of the map. When W3C geolocation fails (or is denied by the user), the page falls back to the old behaviour of showing a world map.
The last commit (mine) is the only one I really wanted to include in this request, but I only have a yellow belt in git so why these other commits appear here is beyond me. My apologies.