Improve textarea behaviour #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravitystorm
requested changes
Dec 18, 2019
There was a problem hiding this comment.
Thanks @hikemaniac! I'm happy with these changes, because:
- The
resize: verticalis the default for bootstrap resets, so if they think it's reasonable that's fine with me. - The border-radius also matches what bootstrap do to text-areas.
- I don't have strong opinions on the min-height aspect of this PR so I'm happy to approve it.
I should note that the border-radius will also be applied to much more than just text-areas, which isn't clear from your description. For example, you can see it on the input fields on the sign in form. However, I think it looks fine there too so I'm happy to do this, after the other requested changes are resolved.
gravitystorm
approved these changes
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
resize: verticalCSS property to comment textareas to fix a problem, where they could be dragged beyond the sidebar.Furthermore, I've added a
min-heightto all textareas to not let them be too small to enable the display of a scrolling bar.I've also added a
border-radiusto form fields, to make them more consistent with what we do with buttons and tables.