Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various CSS fixes #2497

Merged
merged 4 commits into from Jan 9, 2020
Merged

Various CSS fixes #2497

merged 4 commits into from Jan 9, 2020

Conversation

gravitystorm
Copy link
Collaborator

This PR fixes a few CSS issues that were highlighted in #2492 and others that I noticed while working on that. In summary:

  • Uses bootstrap's list-group-flush to replace custom css, for sidebars with lists-with-lines-between
  • Uses h6 for the changeset comment tag text
  • Removes some unnecessary custom css rules
  • Tweaks the rss icon to line it up with other icons

…lists to use list-group-flush

The descriptions are probably best not as a header, but still needs to be something more prominent than surrounding text.
This brings it into line with e.g. the new diary entry icon
@tomhughes tomhughes merged commit 68422c7 into openstreetmap:master Jan 9, 2020
@tomhughes
Copy link
Member

I've added one extra tweak in ffb671b to pull the query tool results back to the left as this change had, probably unintentionally, led to them being indented like this:

before

My change moves them back to the left in line with where they were before:

after

The geocoder search results could probably do with being converted to this new format as well...

@gravitystorm
Copy link
Collaborator Author

probably unintentionally

It was actually deliberate, but I'm not too fussed either way :-) I think the horizontal lines that stretch beyond the left-most character of the heading makes it look like the heading is part of one of the items.

  heading

  stuff
---- divider ---
  stuff

  heading

  stuff
---- divider ---
  stuff
---- divider ---
  stuff

The above looks like a single list of four items with three dividers to me.

  heading

    stuff
  ---- divider
    stuff

  heading

    stuff
  ---- divider
    stuff
  ---- divider
    stuff

The above looks more like two lists, with a header before each list and dividers between the list items.

But like I say, there's perhaps bigger things to worry about! Just thought I should explain my reasoning.

@tomhughes
Copy link
Member

I think it was the lines sticking out beyond the text that I found odd - the actual indentation wasn't particularly unreasonable.

Actually I think it's the combination - the lines sticking out would work if all the text was indented but having some text align with the lines and some not winds up looking a bit weird to me somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants