More CSS cleanups #2709
Merged
More CSS cleanups #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not the menu state Also reworks to be mobile-first
This is the default anyway, and we don't need this for anything specific.
Ideally this would be refactored to be mobile-first, but is likely to be replaced by more general bootstrap form refactoring anyway.
This makes it clearer that the classes are only for navigation menu matters. Other things should be done on media queries, or ideally, using bootstrap components like grids. This has a side effect of removing the smaller font size from the body when the navigation menu is in the small-nav state.
Images have no border in modern browsers, and bootstrap's reset also sets this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several CSS cleanups.
The main theme is continuing the work of disentangling the small screen stuff (which should be done with media breakpoints or builtin bootstrap functionality) from the navigation bar changes (which is based on the length of the text in the menus, not on the screen size).
Various other changes were found during this work too.