Refactoring for to_xml #2999
Merged
Refactoring for to_xml #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every point knows which trace it's associated with, so there's no need to search for it separately
It doesn't make a huge difference, since rails caches all the results of the queries generated by point.trace lookups, but at least it cuts down on the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally going to involve getting rid of the to_xml for tracepoints, and move to a builder view for that, but I got bogged down in the gpx file building stuff and had to abandon that.
So this PR is some stand-alone work that was going to be in that PR but may as well be used separately.