Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync more hash-url-params for iD #3033

Closed
wants to merge 1 commit into from

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Jan 2, 2021

This commit includes a few console.logs since it is still WIP.

It solved part of the issue described in #3031:

Whenever I pan the map in iD, the osm-hash-params get updated with the current iD-in-iframe-configuration.
However, click actions in the iD iframe (eg changing the map layer) don't trigger this update until I also pan the map afterwards.

This is all I could contribute with my limited knowledge of the code. I am pretty sure there is a more elegant solution to this. However, I also think this would already be a bit better than what we have right now …

This commit includes a few console.logs since it is still WIP.

It solved part of the issue described in openstreetmap#3031. Whenever I pan the map in iD, the osm-hash-params get updated witht the current iD-in-iframe-configuration. However, click actions in the iD iframe dont trigger this update, only panning the map.
@tordans
Copy link
Contributor Author

tordans commented May 31, 2024

Lets close this draft for now, it is too old to be useful.

I am still hoping for some improvements here in the future … like

  • one set of url params ?/& that are the same for all/most editors and part of the URL and synced by iD
  • all the other editor state params as part of the URL hash #

That should allow for the website to have a clear and shared URL search params API … but still editors can have custom state to make the UI sharable.

There was some work on syncing the editor state with the URL in facebook/Rapid#1404

@tordans tordans closed this May 31, 2024
@tordans tordans deleted the sync-params-with-id branch May 31, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant