Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename browse controller to queries controller #4616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Contributor

The only thing left in browse controller was the query sidebar.

The query is not run server-side. Actual timeout, if required, should be in javascript.
@tomhughes
Copy link
Member

I fine with this in principle, I just wonder what the right name is and I'm not sure that QueriesController is it.

I started off thinking it should be singular as QueryController which I realise doesn't fit with resourceful naming from using a resource route but then maybe that's the point, that it's not managing a set of resources so shouldn't be a resourceful route?

Then I thought maybe it should be FeaturesController because features are the resource that is being queried? At least that's how the UI describes it...

@AntonKhorev
Copy link
Contributor Author

What's wrong with QueriesController? When you see this controller name, you know it handles either /queries/:id or /query paths. FeaturesController instead you'll have to investigate because there's no "features" route.

If we change the path however... I'm thinking about combining query features with map key. There's a proposal to change the map key icon, but I don't think users will find it significantly more clear. The query button might open the sidebar right away and show map key there. And also sort out #3819, #3833 and #3709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants